lkml.org 
[lkml]   [2018]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] i2c: i801: fix unused-function warning
    Date
    With CONFIG_PM, we get a harmless build warning:
    drivers/i2c/busses/i2c-i801.c:1723:12: warning: ‘i801_resume’ defined but not used [-Wunused-function]
    static int i801_resume(struct device *dev)
    ^~~~~~~~~~~
    drivers/i2c/busses/i2c-i801.c:1714:12: warning: ‘i801_suspend’ defined but not used [-Wunused-function]
    static int i801_suspend(struct device *dev)
    ^~~~~~~~~~~~

    Follow design pattern from other drivers like i2c-brcmstb, i2c-mpc,
    i2c-ocores, i2c-pnx, i2c-puv3, i2c-st, i2c-stu300 and i2c-mux-pca954x
    and changing the ifdef CONFIG_PM to CONFIG_PM_SLEEP.

    Fixes: a9c8088c7988 ("i2c: i801: Don't restore config registers on runtime PM")
    Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
    ---
    drivers/i2c/busses/i2c-i801.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
    index ed07f9002710..954fb3f3b7fc 100644
    --- a/drivers/i2c/busses/i2c-i801.c
    +++ b/drivers/i2c/busses/i2c-i801.c
    @@ -1710,7 +1710,7 @@ static void i801_shutdown(struct pci_dev *dev)
    pci_write_config_byte(dev, SMBHSTCFG, priv->original_hstcfg);
    }

    -#ifdef CONFIG_PM
    +#ifdef CONFIG_PM_SLEEP
    static int i801_suspend(struct device *dev)
    {
    struct pci_dev *pci_dev = to_pci_dev(dev);
    --
    2.17.0
    \
     
     \ /
      Last update: 2018-05-14 11:34    [W:3.153 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site