Messages in this thread | | | Date | Mon, 14 May 2018 22:05:03 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver |
| |
Hi!
> > OK. > > OK I looked at the max776973 driver and well if the flash-max-microamp and > flash-max-timeout-us nodes are missing it sets a default value for each if the > node is not present. > > So should we remove this code from the Max77693 driver too and fail probe as being asked > in this driver?
Well, modifying driver without access to the hardware is tricky :-(. If it does something stupid (like using other than minimum values for the flash-max-microamp/flash-max-timeout-us), it needs to be fixed.
And maybe comment "don't copy this, its wrong" would be in order...
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |