lkml.org 
[lkml]   [2018]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/1] Drivers: hv: vmbus: enable VMBus protocol version 5.0
On Mon, 14 May 2018 18:14:15 +0000
Dexuan Cui <decui@microsoft.com> wrote:

> > From: devel <driverdev-devel-bounces@linuxdriverproject.org> On Behalf Of
> > Stephen Hemminger
> > Sent: Sunday, May 13, 2018 10:24
> > > ...
> > > @@ -372,6 +400,18 @@ int vmbus_post_msg(void *buffer, size_t buflen,
> > bool can_sleep)
> > > ...
> > > + hdr = (struct vmbus_channel_message_header *)buffer;
> >
> > Hate to pick o the details, but buffer is void * so cast is not necessary here.
>
> Yes, it's unnecessary in C, though it's necessary in C++.
>
> I found the patch went into char-misc 4 hours ago, so it looks we may
> as well leave it as is. IMHO an explicit cast is not a bad thing. :-)
>
> Thanks,
> -- Dexuan

Kernel developers like to be concise. In fact there is a smatch script that perodically
gets run and more cleanup patches get sent.

\
 
 \ /
  Last update: 2018-05-14 20:18    [W:0.057 / U:3.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site