lkml.org 
[lkml]   [2018]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 3/3] tty: implement led triggers
    On Tue, May 8, 2018 at 1:05 PM, Uwe Kleine-König
    <u.kleine-koenig@pengutronix.de> wrote:
    > The rx trigger fires when data is pushed to the ldisc by the driver. This
    > is a bit later than the actual receiving of data but has the nice benefit
    > that it doesn't need adaption for each driver and isn't in the hot path.
    >
    > Similarly the tx trigger fires when data was copied from userspace and is
    > given to the ldisc.

    > #include <uapi/linux/tty.h>
    > #include <linux/rwsem.h>
    > #include <linux/llist.h>
    > +#include <linux/leds.h>

    Even for unordered lists of inclusions I would still try to put new
    lines in "somehow" ordered positions.
    For example here, I would rather put it before llist.h.

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2018-05-13 16:23    [W:4.773 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site