Messages in this thread | | | Subject | Re: [RFC PATCH v4 2/3] acpi: apei: Rename ghes_severity() to ghes_cper_severity() | From | "Alex G." <> | Date | Fri, 11 May 2018 12:03:21 -0500 |
| |
On 05/11/2018 11:19 AM, Borislav Petkov wrote: > On Fri, May 11, 2018 at 11:12:24AM -0500, Alex G. wrote: >> Because the GHES structure uses CPER values, but all the code is written >> to use GHES_SEV_ values. GHES_SEV_ is a made up enum, specifically for >> linux. > > Again, what does that even matter?
I will shorten the commit message.
> They're defines in both cases. The *actual* value means shit. > > Ah, I see it: > > ... > sec_sev = ghes_sec_pcie_severity(gdata); > > worst_sev = max(worst_sev, sec_sev); > > > Yeah, no, you can't do that. No apples and oranges comparisons.
That was a mistake on my part. Despite my godlike ability to produce great fixes, I am, in fact, human.
Alex
| |