lkml.org 
[lkml]   [2018]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] media: staging: atomisp:
Date
These 3 patches fixes (at least I hope) some issues found in or around
'lm3554_probe()'.

Please review them carefully. I've only compile tested the changes and
I propose them because they sound logical to me.

The first one, return an error code instead of 0 if the call to an
initialisation function fails.
The 2nd one reorders own some label are reached in order to have a logical
flow (first error goes to last label, last error goes to first label)
The 3rd one fix the use 'media_entity_cleanup()'. If this one is correct,
some other drivers will need to be fixed the same way.

Christophe JAILLET (3):
media: staging: atomisp: Return an error code in case
of error in 'lm3554_probe()'
media: staging: atomisp: Fix an error handling path in
'lm3554_probe()'
media: staging: atomisp: Fix usage of 'media_entity_cleanup()'

.../media/atomisp/i2c/atomisp-lm3554.c | 20 +++++++++----------
1 file changed, 9 insertions(+), 11 deletions(-)

--
2.17.0

\
 
 \ /
  Last update: 2018-05-11 17:07    [W:0.034 / U:0.412 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site