Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module" | Date | Fri, 11 May 2018 13:13:33 +0300 |
| |
Rafał Miłecki <zajec5@gmail.com> writes:
> On 11 May 2018 at 11:17, Rafał Miłecki <zajec5@gmail.com> wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e. >> >> Above commit added "SSB = y" dependency to the wrong symbol >> SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being >> selected when needed. PCI core driver for core running in clienthost >> mode is important for bus initialization. It's perfectly valid scenario >> to have ssb built as module and use it with buses on PCI cards. >> >> This fixes regression that affected all *module* users with PCI cards. >> >> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1572349 >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > As these patches fix regression/build error, I believe both should get > into 4.17.
How much confidence do we have that we don't need to end up reverting patch 2 as well? I rather be pushing patch 2 to 4.18 so that there's more time for testing and waiting for feedback.
-- Kalle Valo
| |