lkml.org 
[lkml]   [2018]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver
Hi!

> Introduce the device tree bindings for the lm3601x
> family of LED torch, flash and IR drivers.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

Better, thanks.
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> @@ -0,0 +1,50 @@
> +* Texas Instruments - lm3601x Single-LED Flash Driver

Ok, so is it single-LED driver, or can it driver ir & white LEDs at
the same time?

> +Example:
> +led-controller@64 {
> + compatible = "ti,lm36010";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x64>;
> +
> + led@0 {
> + reg = <0>;
> + label = "white:torch";
> + led-max-microamp = <10000>;
> + };
> +
> + led@1 {
> + reg = <1>;
> + label = "white:flash";
> + flash-max-microamp = <10000>;
> + flash-max-timeout-us = <800>;
> + };

Is this realistic config? I'd expect flash to use more power than
torch, and would expect longer timeout than 0.8msec.

Also.. if this is physically one white LED, it should not be
spread over reg = <0> and reg = <1>...

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-05-10 20:54    [W:0.096 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site