Messages in this thread | | | Date | Thu, 10 May 2018 08:26:02 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v15 9/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC |
| |
On Thu, May 03, 2018 at 01:03:58AM -0400, Oza Pawandeep wrote: > This patch disables ERR_NONFATAL trigger for DPC, so now DPC > handles only ERR_FATAL. > ...
> diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 103ba79..86f1cc2 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -981,6 +981,7 @@ > #define PCI_EXP_DPC_CAP_DL_ACTIVE 0x1000 /* ERR_COR signal on DL_Active supported */ > > #define PCI_EXP_DPC_CTL 6 /* DPC control */ > +#define PCI_EXP_DPC_CTL_EN_FATAL 0x0001 /* Enable trigger on ERR_FATAL message */
There's a tab instead of a space after the #define. The other #defines use a space. Looks the same in the end, but makes the patch look funny.
> #define PCI_EXP_DPC_CTL_EN_NONFATAL 0x0002 /* Enable trigger on ERR_NONFATAL message */ > #define PCI_EXP_DPC_CTL_INT_EN 0x0008 /* DPC Interrupt Enable */ > > -- > 2.7.4 >
| |