lkml.org 
[lkml]   [2018]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 111/293] kselftests: timers: Fix inconsistency-check to not ignore first timestamp
    Date
    From: Miroslav Lichvar <mlichvar@redhat.com>

    [ Upstream commit 7a5de5512296fd2ab7a497e4a576196b1f046e78 ]

    When the first timestamp in the list of clock readings was later than
    the second timestamp and all other timestamps were in order, the
    inconsistency was not reported because the index of the out-of-order
    timestamp was equal to the default value.

    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Miroslav Lichvar <mlichvar@redhat.com>
    Cc: Richard Cochran <richardcochran@gmail.com>
    Cc: Prarit Bhargava <prarit@redhat.com>
    Cc: Stephen Boyd <stephen.boyd@linaro.org>
    Cc: Shuah Khan <shuah@kernel.org>
    Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>
    Signed-off-by: John Stultz <john.stultz@linaro.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    tools/testing/selftests/timers/inconsistency-check.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c
    index caf1bc9257c4..74c60e8759a0 100644
    --- a/tools/testing/selftests/timers/inconsistency-check.c
    +++ b/tools/testing/selftests/timers/inconsistency-check.c
    @@ -118,7 +118,7 @@ int consistency_test(int clock_type, unsigned long seconds)
    start_str = ctime(&t);

    while (seconds == -1 || now - then < seconds) {
    - inconsistent = 0;
    + inconsistent = -1;

    /* Fill list */
    for (i = 0; i < CALLS_PER_LOOP; i++)
    @@ -130,7 +130,7 @@ int consistency_test(int clock_type, unsigned long seconds)
    inconsistent = i;

    /* display inconsistency */
    - if (inconsistent) {
    + if (inconsistent >= 0) {
    unsigned long long delta;

    printf("\%s\n", start_str);
    --
    2.15.1
    \
     
     \ /
      Last update: 2018-04-09 04:22    [W:4.019 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site