| From | Sasha Levin <> | Subject | [PATCH AUTOSEL for 4.15 007/189] tipc: fix a potental access after delete in tipc_sk_join() | Date | Mon, 9 Apr 2018 00:16:49 +0000 |
| |
From: Jon Maloy <jon.maloy@ericsson.com>
[ Upstream commit febafc8455fdbb0ba53d596075068a683b75f355 ]
In commit d12d2e12cec2 "tipc: send out join messages as soon as new member is discovered") we added a call to the function tipc_group_join() without considering the case that the preceding tipc_sk_publish() might have failed, and the group item already deleted.
We fix this by returning from tipc_sk_join() directly after the failed tipc_sk_publish.
Reported-by: syzbot+e3eeae78ea88b8d6d858@syzkaller.appspotmail.com Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> --- net/tipc/socket.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 3b4084480377..8efd2e42de30 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -2759,6 +2759,7 @@ static int tipc_sk_join(struct tipc_sock *tsk, struct tipc_group_req *mreq) if (rc) { tipc_group_delete(net, grp); tsk->group = NULL; + return rc; } /* Eliminate any risk that a broadcast overtakes the sent JOIN */ -- 2.15.1
|