lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 72/93] media: media/v4l2-ctrls: volatiles should not generate CH_VALUE
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ricardo Ribalda <ricardo.ribalda@gmail.com>

    Volatile controls should not generate CH_VALUE events.

    Set has_changed to false to prevent this happening.

    Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/v4l2-core/v4l2-ctrls.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    --- a/drivers/media/v4l2-core/v4l2-ctrls.c
    +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
    @@ -1619,6 +1619,15 @@ static int cluster_changed(struct v4l2_c

    if (ctrl == NULL)
    continue;
    + /*
    + * Set has_changed to false to avoid generating
    + * the event V4L2_EVENT_CTRL_CH_VALUE
    + */
    + if (ctrl->flags & V4L2_CTRL_FLAG_VOLATILE) {
    + ctrl->has_changed = false;
    + continue;
    + }
    +
    for (idx = 0; !ctrl_changed && idx < ctrl->elems; idx++)
    ctrl_changed = !ctrl->type_ops->equal(ctrl, idx,
    ctrl->p_cur, ctrl->p_new);

    \
     
     \ /
      Last update: 2018-04-06 17:20    [W:4.977 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site