Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 6 Apr 2018 17:01:07 +0300 | Subject | Re: [PATCH v6 3/9] pinctrl: actions: Add Actions S900 pinctrl driver |
| |
On Tue, Apr 3, 2018 at 8:00 PM, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
>> > +static const struct pinconf_ops owl_pinconf_ops = { >> > + .is_generic = true, >> > + .pin_config_get = owl_pin_config_get, >> > + .pin_config_set = owl_pin_config_set, >> > + .pin_config_group_get = owl_group_config_get, >> > + .pin_config_group_set = owl_group_config_set >> >> It's still good idea to leave comma here...
> I'm confused. What is the criteria for removing/keeping comma for last member > of struct? I followed your gpio driver suggestion.
Just a common sense and experience are talking here: from time to time some structures are being expanded and in some cases it requires to update users. The comma just reduces a possible burden on this expansion. This is common pattern used in kernel.
>> > +}; >> > + >> > +static struct pinctrl_desc owl_pinctrl_desc = { >> > + .pctlops = &owl_pinctrl_ops, >> > + .pmxops = &owl_pinmux_ops, >> > + .confops = &owl_pinconf_ops, >> > + .owner = THIS_MODULE >> >> ...and here, and in all similar places. >> >> > +};
-- With Best Regards, Andy Shevchenko
| |