lkml.org 
[lkml]   [2018]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane
    From
    Date
    On 04/05/2018 12:03 PM, Daniel Vetter wrote:
    >
    > On the topic of input validation: Should the kernel check in shared code
    > that all the clip rects are sensible, i.e. within the dimensions of the
    > fb? Relying on drivers for that seems like a bad idea.

    I guess we could do that.

    There seems to be different needs for different kinds of iterators, but
    otherwise
    I was thinking that an iterator could just skip invalid rects if found.
    Then we
    don't need a separate validation step, but OTOH user-space won't get
    notified if
    that was intended.

    I'm not 100% sure user-space would do anything sensible with any error
    information, though.

    /Thomas


    >
    > That could be done in core code in drm_atomic_plane_check().
    > -Daniel
    >> /Thomas
    >>
    >>
    >> _______________________________________________
    >> dri-devel mailing list
    >> dri-devel@lists.freedesktop.org
    >> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_dri-2Ddevel&d=DwIBAg&c=uilaK90D4TOVoH58JNXRgQ&r=wnSlgOCqfpNS4d02vP68_E9q2BNMCwfD2OZ_6dCFVQQ&m=JV7fhQ4zTiyiKsY8M0Zlf81l7szYePUke8kwSvQv1T8&s=HEcbr-8aoWqRvWGY6RcL1QeAtEyxMRLHbsOtdJFk78I&e=


    \
     
     \ /
      Last update: 2018-04-05 13:42    [W:2.753 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site