lkml.org 
[lkml]   [2018]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] ib_srpt: depend on INFINIBAND_ADDR_TRANS
On Wed, Apr 25, 2018 at 03:33:39PM -0700, Greg Thelen wrote:
> INFINIBAND_SRPT code depends on INFINIBAND_ADDR_TRANS provided symbols.
> So declare the kconfig dependency. This is necessary to allow for
> enabling INFINIBAND without INFINIBAND_ADDR_TRANS.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
> Cc: Tarick Bedeir <tarick@google.com>
> drivers/infiniband/ulp/srpt/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/Kconfig b/drivers/infiniband/ulp/srpt/Kconfig
> index 31ee83d528d9..fb8b7182f05e 100644
> +++ b/drivers/infiniband/ulp/srpt/Kconfig
> @@ -1,6 +1,6 @@
> config INFINIBAND_SRPT
> tristate "InfiniBand SCSI RDMA Protocol target support"
> - depends on INFINIBAND && TARGET_CORE
> + depends on INFINIBAND && INFINIBAND_ADDR_TRANS && TARGET_CORE

Isn't INFINIBAND && INFINIBAND_ADDR_TRANS a bit redundant? Can't have
INFINIBAND_ADDR_TRANS without INFINIBAND.

Jason

\
 
 \ /
  Last update: 2018-05-01 01:35    [W:0.073 / U:1.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site