Messages in this thread | | | Date | Tue, 3 Apr 2018 09:27:24 +0200 | From | Mylène Josserand <> | Subject | Re: [PATCH v5 01/13] ARM: move cputype definitions into another file |
| |
Hi Chen-Yu,
Thank you for your review!
On Tue, 3 Apr 2018 14:52:45 +0800 Chen-Yu Tsai <wens@csie.org> wrote:
> On Tue, Apr 3, 2018 at 2:18 PM, Mylène Josserand > <mylene.josserand@bootlin.com> wrote: > > To add the support for SMP on sun8i-a83t, we will use some > > definitions in an assembly file so move definitions into > > another file to separate C functions and macro defintions. > > Instead of moving the definitions, you could guard all the C > stuff in "#ifndef __ASSEMBLY__". AFAIK a few header files do that.
Oh, right. It is better with this check so I will use that in the next iteration of my series.
Best regards,
Mylène
-- Mylène Josserand, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
> > ChenYu > > > Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com> > > --- > > arch/arm/include/asm/cputype.h | 94 +----------------------------------- > > arch/arm/include/asm/cputype_def.h | 98 ++++++++++++++++++++++++++++++++++++++
| |