Messages in this thread | | | Subject | Re: [PATCH] nvme: change order of qid and cmdid in completion trace | From | Jens Axboe <> | Date | Thu, 26 Apr 2018 14:01:59 -0600 |
| |
On 4/26/18 1:49 PM, Johannes Thumshirn wrote: > Keith reported that command submission and command completion > tracepoints have the order of the cmdid and qid fileds swapped. > > While it isn't easily possible to change the command submission > tracepoint, as there is a regression test parsing it in blktests we > can swap the command completion tracepoint to have the fileds aligned.
It also makes more sense to have qid before cmdid.
Also, fileds -> fields, in two spots.
With that:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
-- Jens Axboe
| |