lkml.org 
[lkml]   [2018]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()
Date
Use devm_request_irq() instead of request_irq() to request the IRQ.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
---

Hi Lars,

was there a specific reason not to use devm_request_irq() ?

Cheers,

Moritz

---
drivers/dma/dma-axi-dmac.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 2419fe524daa..75ccedaa96d2 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -687,8 +687,9 @@ static int axi_dmac_probe(struct platform_device *pdev)
if (ret)
goto err_unregister_device;

- ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
- dev_name(&pdev->dev), dmac);
+ ret = devm_request_irq(&pdev->dev, dmac->irq,
+ axi_dmac_interrupt_handler, 0,
+ dev_name(&pdev->dev), dmac);
if (ret)
goto err_unregister_of;

@@ -711,7 +712,6 @@ static int axi_dmac_remove(struct platform_device *pdev)
struct axi_dmac *dmac = platform_get_drvdata(pdev);

of_dma_controller_free(pdev->dev.of_node);
- free_irq(dmac->irq, dmac);
tasklet_kill(&dmac->chan.vchan.task);
dma_async_device_unregister(&dmac->dma_dev);
clk_disable_unprepare(dmac->clk);
--
2.17.0
\
 
 \ /
  Last update: 2018-04-26 18:19    [W:0.086 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site