lkml.org 
[lkml]   [2018]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Revert "x86/mm: implement free pmd/pte page interfaces"
    On Thu, Apr 26, 2018 at 05:14:07PM +0200, Joerg Roedel wrote:
    > From: Joerg Roedel <jroedel@suse.de>
    >
    > This reverts commit 28ee90fe6048fa7b7ceaeb8831c0e4e454a4cf89.
    >
    > This commit is broken for x86, as it unmaps the PTE and PMD
    > pages and immediatly frees them without doing a TLB flush.
    >
    > Further this lacks synchronization with other page-tables in
    > the system when the PMD pages are not shared between
    > mm_structs.
    >
    > On x86-32 with PAE and PTI patches on-top this patch
    > triggers the BUG_ON in vmalloc_sync_one() because the kernel
    > and the process page-table were not synchronized.
    >
    > Signed-off-by: Joerg Roedel <jroedel@suse.de>
    > ---
    > arch/x86/mm/pgtable.c | 28 ++--------------------------
    > 1 file changed, 2 insertions(+), 26 deletions(-)

    <formletter>

    This is not the correct way to submit patches for inclusion in the
    stable kernel tree. Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
    for how to do this properly.

    </formletter>

    \
     
     \ /
      Last update: 2018-04-26 17:27    [W:3.626 / U:1.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site