lkml.org 
[lkml]   [2018]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] of: overlay: Stop leaking resources on overlay removal
On Thu, Apr 26, 2018 at 01:00:30PM +0200, Jan Kiszka wrote:
> Only the overlay notifier callbacks have a chance to potentially get
> hold of references to those two resources, but they are not supposed to
> store them beyond OF_OVERLAY_POST_REMOVE.
>
> Document the overlay notifier API, its constraint regarding pointer
> lifetime, and then remove intentional leaks of ovcs->overlay_tree and
> ovcs->fdt from free_overlay_changeset.
>
> See also https://lkml.org/lkml/2018/4/23/1063 and following.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> Documentation/devicetree/overlay-notes.txt | 8 ++++++++
> drivers/of/overlay.c | 30 +++++++++++++++++++++---------
> 2 files changed, 29 insertions(+), 9 deletions(-)

Applied, thanks.

Rob

\
 
 \ /
  Last update: 2018-04-27 04:20    [W:0.149 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site