Messages in this thread | | | From | Laurent Pinchart <> | Subject | Re: [PATCH] drm/bridge: tc358767: fix mode_valid's return type | Date | Fri, 27 Apr 2018 02:22:14 +0300 |
| |
Hi Luc,
Thank you for the patch.
On Tuesday, 24 April 2018 16:14:52 EEST Luc Van Oostenryck wrote: > The method struct drm_connector_helper_funcs::mode_valid is defined > as returning an 'enum drm_mode_status' but the driver implementation > for this method uses an 'int' for it. > > Fix this by using 'enum drm_mode_status' in the driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> --- > drivers/gpu/drm/bridge/tc358767.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c > b/drivers/gpu/drm/bridge/tc358767.c index 08ab7d6ae..0fd9cf275 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -1102,7 +1102,7 @@ static bool tc_bridge_mode_fixup(struct drm_bridge > *bridge, return true; > } > > -static int tc_connector_mode_valid(struct drm_connector *connector, > +static enum drm_mode_status tc_connector_mode_valid(struct drm_connector > *connector, struct drm_display_mode *mode) > { > /* DPI interface clock limitation: upto 154 MHz */
-- Regards,
Laurent Pinchart
| |