lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC v2 2/2] pmem: device flush over VIRTIO

    >
    > On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta <pagupta@redhat.com> wrote:
    > > This patch adds functionality to perform
    > > flush from guest to hosy over VIRTIO
    > > when 'ND_REGION_VIRTIO'flag is set on
    > > nd_negion. Flag is set by 'virtio-pmem'
    > > driver.
    > >
    > > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
    > > ---
    > > drivers/nvdimm/region_devs.c | 7 +++++++
    > > 1 file changed, 7 insertions(+)
    > >
    > > diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c
    > > index a612be6..6c6454e 100644
    > > --- a/drivers/nvdimm/region_devs.c
    > > +++ b/drivers/nvdimm/region_devs.c
    > > @@ -20,6 +20,7 @@
    > > #include <linux/nd.h>
    > > #include "nd-core.h"
    > > #include "nd.h"
    > > +#include <linux/virtio_pmem.h>
    > >
    > > /*
    > > * For readq() and writeq() on 32-bit builds, the hi-lo, lo-hi order is
    > > @@ -1074,6 +1075,12 @@ void nvdimm_flush(struct nd_region *nd_region)
    > > struct nd_region_data *ndrd = dev_get_drvdata(&nd_region->dev);
    > > int i, idx;
    > >
    > > + /* call PV device flush */
    > > + if (test_bit(ND_REGION_VIRTIO, &nd_region->flags)) {
    > > + virtio_pmem_flush(&nd_region->dev);
    > > + return;
    > > + }
    > > +
    >
    > I'd rather introduce a ->flush() operation hanging off of 'struct
    > nd_region' so that this multiplexing can be a static setting.

    Sure! will make the change.

    Thanks,
    Pankaj

    \
     
     \ /
      Last update: 2018-04-25 16:49    [W:2.536 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site