Messages in this thread | | | Subject | Re: [PATCH] can: dev: increase bus-off message severity | From | Marc Kleine-Budde <> | Date | Wed, 25 Apr 2018 16:42:18 +0200 |
| |
On 04/18/2018 04:10 PM, Jakob Unterwurzacher wrote: > bus-off is usually caused by hardware malfunction or > configuration error (baud rate mismatch) and causes a > complete loss of communication. > > Increase the "bus-off" message's severity from netdev_dbg > to netdev_info to make it visible to the user. > > A can interface going into bus-off is similar in severity to > ethernet's "Link is Down" message, which is also printed > at info level. > > It is debatable whether the the "restarted" message should > also be changed to netdev_info to make the interface state > changes comprehensible from the kernel log. > I have chosen to keep the "restarted" message at dbg for now > as the "bus-off" message should be enough for the user to > notice and investigate the problem. > > Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > Cc: linux-can@vger.kernel.org > Cc: linux-kernel@vger.kernel.org
Applied to can.
Tnx, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[unhandled content-type:application/pgp-signature] | |