Messages in this thread Patch in this message | | | Date | Wed, 25 Apr 2018 09:59:07 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 4/5] perf parse-events: Specially handle uncore event alias in small groups |
| |
Em Wed, Apr 25, 2018 at 08:27:31AM -0400, Liang, Kan escreveu: > > > On 4/24/2018 3:29 PM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Apr 24, 2018 at 03:23:06PM -0400, Liang, Kan escreveu: > > > On 4/24/2018 3:17 PM, Arnaldo Carvalho de Melo wrote: > > > > Em Tue, Apr 24, 2018 at 11:20:13AM -0700, kan.liang@linux.intel.com escreveu: > > > > > From: Kan Liang <kan.liang@linux.intel.com> > > > > > > > > > > Perf stat doesn't count the uncore event aliases from the same uncore > > > > > block in a group, for example: > > > > > > > > This one is not applying to acme/perf/urgent, all the rest I got merged > > > > there, the last one with that change from using strstr() to a new bool > > > > in perf_evsel for the uniquifying operation having being performed. > > > > > > Sure. Thank you for letting me know. > > > > Just pushed what I have there, > > > > Thanks Arnaldo. > > How about this one? > Will it be applied to acme/perf/core? Or should I resend it for wider > review?
On acme/perf/urgent, please check
[acme@seventh perf]$ patch -p1 < /wb/1.patch patching file tools/perf/util/evsel.h Hunk #1 succeeded at 127 (offset 1 line). patching file tools/perf/util/parse-events.c patching file tools/perf/util/parse-events.h patching file tools/perf/util/parse-events.y Hunk #3 FAILED at 232. 1 out of 4 hunks FAILED -- saving rejects to file tools/perf/util/parse-events.y.rej [acme@seventh perf]$ cat tools/perf/util/parse-events.y.rej --- tools/perf/util/parse-events.y +++ tools/perf/util/parse-events.y @@ -232,7 +232,7 @@ PE_NAME opt_event_config YYABORT; ALLOC_LIST(list); - if (parse_events_add_pmu(_parse_state, list, $1, $2, false)) { + if (parse_events_add_pmu(_parse_state, list, $1, $2, false, false)) { struct perf_pmu *pmu = NULL; int ok = 0; char *pattern; [acme@seventh perf]$
| |