Messages in this thread | | | Date | Wed, 25 Apr 2018 12:51:41 +0300 | From | Mika Westerberg <> | Subject | Re: [RFC PATCH RESEND 1/3] mfd: upboard: Add UP2 platform controller driver |
| |
On Sat, Apr 21, 2018 at 09:50:07AM +0100, Javier Arteaga wrote: > +static const struct acpi_device_id upboard_acpi_match[] = { > + { "AANT0F01", (kernel_ulong_t) &upboard_up2_data },
No space after cast so write it like,
{ "AANT0F01", (kernel_ulong_t)&upboard_up2_data },
> + { } > +}; > +MODULE_DEVICE_TABLE(acpi, upboard_acpi_match); > + > +static int upboard_probe(struct platform_device *pdev) > +{ > + struct upboard *upboard; > + const struct acpi_device_id *id; > + const struct upboard_data *upboard_data; > + int ret; > + > + id = acpi_match_device(upboard_acpi_match, &pdev->dev); > + if (!id) > + return -ENODEV; > + > + upboard_data = (const struct upboard_data *) id->driver_data;
Ditto and to other places.
Otherwise looks good to me.
| |