lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH RESEND 1/3] mfd: upboard: Add UP2 platform controller driver
    On Sat, Apr 21, 2018 at 09:50:07AM +0100, Javier Arteaga wrote:
    > +static const struct acpi_device_id upboard_acpi_match[] = {
    > + { "AANT0F01", (kernel_ulong_t) &upboard_up2_data },

    No space after cast so write it like,

    { "AANT0F01", (kernel_ulong_t)&upboard_up2_data },


    > + { }
    > +};
    > +MODULE_DEVICE_TABLE(acpi, upboard_acpi_match);
    > +
    > +static int upboard_probe(struct platform_device *pdev)
    > +{
    > + struct upboard *upboard;
    > + const struct acpi_device_id *id;
    > + const struct upboard_data *upboard_data;
    > + int ret;
    > +
    > + id = acpi_match_device(upboard_acpi_match, &pdev->dev);
    > + if (!id)
    > + return -ENODEV;
    > +
    > + upboard_data = (const struct upboard_data *) id->driver_data;

    Ditto and to other places.

    Otherwise looks good to me.

    \
     
     \ /
      Last update: 2018-04-25 11:52    [W:4.054 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site