Messages in this thread | | | From | Jani Nikula <> | Subject | Re: [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type | Date | Tue, 24 Apr 2018 18:11:47 +0300 |
| |
On Tue, 24 Apr 2018, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote: > All implementations of the method intel_dvo_dev_ops::mode_valid(), as > well as the underlying struct drm_connector_helper_funcs::mode_valid() > use 'enum drm_mode_status' for the method's return type but the > declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it. > > Fix this by using 'enum drm_mode_status' for the declaration too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > --- > drivers/gpu/drm/i915/dvo.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h > index 5e6a3013d..b6e143ebc 100644 > --- a/drivers/gpu/drm/i915/dvo.h > +++ b/drivers/gpu/drm/i915/dvo.h > @@ -74,7 +74,7 @@ struct intel_dvo_dev_ops { > * > * \return MODE_OK if the mode is valid, or another MODE_* otherwise. > */ > - int (*mode_valid)(struct intel_dvo_device *dvo, > + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo, > struct drm_display_mode *mode);
Please adjust the alignment here as well. With that,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Oh, and as far as lists go, intel-gfx is sufficient.
> > /*
-- Jani Nikula, Intel Open Source Technology Center
| |