Messages in this thread | | | Date | Tue, 24 Apr 2018 16:12:48 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 20/39] afs: simplify procfs code |
| |
On Fri, Apr 20, 2018 at 01:29:34PM +0100, David Howells wrote: > David Howells <dhowells@redhat.com> wrote: > > > > Use remove_proc_subtree to remove the whole subtree on cleanup, and > > > unwind the registration loop into individual calls. Switch to use > > > proc_create_seq where applicable. > > > > Note that this is likely going to clash with my patch to net-namespace all of > > the afs proc files: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=mount-context&id=f60c26c827c073583107ebf19d87bc5c0e71c3d2 > > > > If it helps, I should be able to disentangle this from the mount-api changes > > since the subsequent patch connects the dots to propagate the network > > namespace over automount using the new fs_context to do it. > > Okay, I'll follow up this mail with a pair of patches to just use network > namespacing in AFS. The first exports a function from core code only; the > second is the actual modifications to AFS.
I don't think you should need any of these. seq_file_net or seq_file_single_net will return you the net_ns based on a struct seq_file. And even from your write routines you can reach the seq_file in file->private pretty easily.
| |