lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: set kernel end address properly
On Tue, 24 Apr 2018 08:13:57 +0200
Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> On 23 April 2018 at 23:43, Kim Phillips <kim.phillips@arm.com> wrote:
> > arch__normalize_symbol_name() is a place where architecture code can
> > clean up symbol names in perf, and I thought module_emit_adrp_veneer()
> > was a veneer itself, but it seems that's not the case, so the
> > literal string check for it shouldn't be needed. The test is still
> > failing though because it doesn't show up in kallsyms...
>
> This turns out to be an unintended side effect of the fact that we
> (I?) taught kallsyms to disregard symbols ending in "_veneer"
>
> So we should probably rename the function, and everything will be fine.

ok so what should we rename module_emit_adrp_veneer to?:

module_emit_adrp_veneer_
module_emit_adrp_veneer_fn
module_emit_adrp_veneer_nokallsyms

or..?

Kim

\
 
 \ /
  Last update: 2018-04-24 14:50    [W:0.115 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site