lkml.org 
[lkml]   [2018]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RESEND PATCH v6 07/27] drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel
    Date
    From: Lin Huang <hl@rock-chips.com>

    When panel is shut down, we should make sure edp can be disabled to avoid
    undefined behavior.

    Cc: Stéphane Marchesin <marcheu@chromium.org>
    Signed-off-by: Lin Huang <hl@rock-chips.com>
    Signed-off-by: zain wang <wzz@rock-chips.com>
    Signed-off-by: Sean Paul <seanpaul@chromium.org>
    Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
    Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
    Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Reviewed-by: Archit Taneja <architt@codeaurora.org>
    ---

    drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++++++++
    1 file changed, 11 insertions(+)

    diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
    index 3269deec739d..5957e2338071 100644
    --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
    +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
    @@ -1160,6 +1160,12 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp)

    pm_runtime_get_sync(dp->dev);

    + ret = clk_prepare_enable(dp->clock);
    + if (ret < 0) {
    + DRM_ERROR("Failed to prepare_enable the clock clk [%d]\n", ret);
    + goto out_dp_clk_pre;
    + }
    +
    if (dp->plat_data->power_on)
    dp->plat_data->power_on(dp->plat_data);

    @@ -1191,6 +1197,8 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp)
    phy_power_off(dp->phy);
    if (dp->plat_data->power_off)
    dp->plat_data->power_off(dp->plat_data);
    + clk_disable_unprepare(dp->clock);
    +out_dp_clk_pre:
    pm_runtime_put_sync(dp->dev);

    return ret;
    @@ -1233,11 +1241,14 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge)
    }

    disable_irq(dp->irq);
    + analogix_dp_set_analog_power_down(dp, POWER_ALL, 1);
    phy_power_off(dp->phy);

    if (dp->plat_data->power_off)
    dp->plat_data->power_off(dp->plat_data);

    + clk_disable_unprepare(dp->clock);
    +
    pm_runtime_put_sync(dp->dev);

    ret = analogix_dp_prepare_panel(dp, false, true);
    --
    2.17.0
    \
     
     \ /
      Last update: 2018-04-23 12:57    [W:3.357 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site