lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 12/21] rcu: Cleanup, don't put ->completed into an int
    Date
    It is true that currently only the low-order two bits are used, so
    there should be no problem given modern machines and compilers, but
    good hygiene and maintainability dictates use of an unsigned long
    instead of an int. This commit therefore makes this change.

    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    ---
    kernel/rcu/tree.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
    index fbacc486ed4c..c7b1e6b2a3da 100644
    --- a/kernel/rcu/tree.c
    +++ b/kernel/rcu/tree.c
    @@ -1765,7 +1765,7 @@ rcu_start_future_gp(struct rcu_node *rnp, struct rcu_data *rdp,
    */
    static bool rcu_future_gp_cleanup(struct rcu_state *rsp, struct rcu_node *rnp)
    {
    - int c = rnp->completed;
    + unsigned long c = rnp->completed;
    bool needmore;
    struct rcu_data *rdp = this_cpu_ptr(rsp->rda);

    --
    2.5.2
    \
     
     \ /
      Last update: 2018-04-23 05:05    [W:4.199 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site