lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 085/196] ext4: shutdown should not prevent get_write_access
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit 576d18ed60f5465110087c5e0eb1010de13e374d upstream.

    The ext4 forced shutdown flag needs to prevent new handles from being
    started, but it needs to allow existing handles to complete. So the
    forced shutdown flag should not force ext4_journal_get_write_access to
    fail.

    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/ext4_jbd2.c | 7 -------
    1 file changed, 7 deletions(-)

    --- a/fs/ext4/ext4_jbd2.c
    +++ b/fs/ext4/ext4_jbd2.c
    @@ -166,13 +166,6 @@ int __ext4_journal_get_write_access(cons
    might_sleep();

    if (ext4_handle_valid(handle)) {
    - struct super_block *sb;
    -
    - sb = handle->h_transaction->t_journal->j_private;
    - if (unlikely(ext4_forced_shutdown(EXT4_SB(sb)))) {
    - jbd2_journal_abort_handle(handle);
    - return -EIO;
    - }
    err = jbd2_journal_get_write_access(handle, bh);
    if (err)
    ext4_journal_abort_handle(where, line, __func__, bh,

    \
     
     \ /
      Last update: 2018-04-22 17:56    [W:4.077 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site