lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 087/164] RDMA/mlx5: Protect from NULL pointer derefence
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Leon Romanovsky <leonro@mellanox.com>

    commit 4289861d88d6c7b5e4c8cc7fe2ad6cdf0cdfc366 upstream.

    The mlx5_ib_alloc_implicit_mr() can fail to acquire pages
    and the returned mr pointer won't be valid. Ensure that it
    is not error prior to access.

    Cc: <stable@vger.kernel.org> # 4.10
    Fixes: 81713d3788d2 ("IB/mlx5: Add implicit MR support")
    Reported-by: Noa Osherovich <noaos@mellanox.com>
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/hw/mlx5/mr.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/infiniband/hw/mlx5/mr.c
    +++ b/drivers/infiniband/hw/mlx5/mr.c
    @@ -1220,6 +1220,8 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct
    return ERR_PTR(-EINVAL);

    mr = mlx5_ib_alloc_implicit_mr(to_mpd(pd), access_flags);
    + if (IS_ERR(mr))
    + return ERR_CAST(mr);
    return &mr->ibmr;
    }
    #endif

    \
     
     \ /
      Last update: 2018-04-22 17:24    [W:4.258 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site