Messages in this thread Patch in this message | | | From | David Herrmann <> | Date | Fri, 20 Apr 2018 08:49:10 +0200 | Subject | Re: [RFC/RFT patch 0/7] timekeeping: Unify clock MONOTONIC and clock BOOTTIME |
| |
Hi
On Fri, Apr 20, 2018 at 7:44 AM, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote: > On (04/20/18 06:37), David Herrmann wrote: >> >> I get lots of timer-errors on Arch-Linux booting current master, after >> a suspend/resume cycle. Just a selection of errors I see on resume: > > Hello David, > Any chance you can revert the patches in question and test? I'm running > ARCH (4.17.0-rc1-dbg-00042-gaa03ddd9c434) and suspend/resume cycle does > not trigger any errors. Except for this one > > kernel: do_IRQ: 0.55 No irq handler for vector
I can easily reproduce it by sleeping for >5min, so the systemd watchdog timers are triggered. The patches don't revert cleanly, so I didn't look into booting without them, yet. I will try just linking the monotonic clock to the monotonic_active clock later.
Also, doesn't this hunk in 72199320d49d need a 'break;':
diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c index b258bee13b02..6259dbc0191a 100644 --- a/kernel/time/posix-stubs.c +++ b/kernel/time/posix-stubs.c @@ -73,6 +73,8 @@ int do_clock_gettime(clockid_t which_clock, struct timespec64 *tp) case CLOCK_BOOTTIME: get_monotonic_boottime64(tp); break; + case CLOCK_MONOTONIC_ACTIVE: + ktime_get_active_ts64(tp); default: return -EINVAL; }
| |