Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 20 Apr 2018 08:28:28 +0200 | Subject | Re: [PATCH v3 1/5] clk: Extract OF clock helpers in <linux/of_clk.h> |
| |
Hi Stephen, Rob,
On Fri, Apr 20, 2018 at 12:25 AM, Stephen Boyd <sboyd@kernel.org> wrote: > Quoting Geert Uytterhoeven (2018-04-18 07:50:01) >> The use of of_clk_get_parent_{count,name}() and of_clk_init() is not >> limited to clock providers. >> >> Hence move these helpers into their own header file, so callers that are >> not clock providers no longer have to include <linux/clk-provider.h>. >> >> Suggested-by: Stephen Boyd <sboyd@kernel.org> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> Reviewed-by: Heiko Stuebner <heiko@sntech.de> >> --- >> v3: >> - Add Reviewed-by, >> - Add SPDX-License-Identifier, >> - Add to clock section in MAINTAINERS (note that Rob is still listed >> as a maintainer, too, due to the include/linux/of*.h catch-all >> rule), > > Can you X: out this file so Rob is happy? Or that doesn't work?
I guess that should work.
My point here is that due to the catch-all rule, he's listed as maintainer for of_{dma,gpio,irq,iommu,mdio,net,pci} too, which are all helpers for other subsystems. Perhaps these should be X'd-out too? Or is it OK without X-ing them out, as the clock maintainers are now shown, too?
Rob: What's your preference?
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |