lkml.org 
[lkml]   [2018]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[patch V2 0/8] rslib: Cleanup and VLA removal
Kees tried to get rid of the Variable Length Arrays in the Reed-Solomon
library by replacing them with fixed length arrays on stack. Though they
are rather large and Andrew did not fall in love with that solution.

This series addresses that in a different way by splitting the rs control
structure up, so that each invocation of rs_init() returns a new instance
in which the decoder buffers are allocated. The polynom tables which build
the base for the RS codecs are still shareable between the instances to
avoid large allocations and initializations of the same data over and over.

The usage sites have been audited and fixed up where necessary to
accomodate the decoder change which forbids parallel decoder invocation for
a particular rs control instance to prevent buffer corruption.

While at it the patch set tidies up the code and converts the related files
over to use SPDX license identifiers.

Changes since V1:

Simplify error path in the diskonchip code and use the proper
function to free the decoder.

As this spawns multiple subsystems it should either go through Andrews tree
or Kees can route it with his other hardening stuff.

Thanks,

tglx

8<---------------
drivers/md/dm-verity-fec.c | 7 +
drivers/mtd/nand/raw/cafe_nand.c | 7 -
drivers/mtd/nand/raw/diskonchip.c | 67 +++++-------
include/linux/rslib.h | 46 ++++----
lib/reed_solomon/decode_rs.c | 34 +++---
lib/reed_solomon/encode_rs.c | 15 --
lib/reed_solomon/reed_solomon.c | 203 ++++++++++++++++++++++----------------
7 files changed, 205 insertions(+), 174 deletions(-)



\
 
 \ /
  Last update: 2018-04-19 12:11    [W:0.103 / U:1.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site