lkml.org 
[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845
Date
Quoting Amit Nischal (2018-04-18 06:03:49)
> On 2018-04-17 09:21, Stephen Boyd wrote:
> > Quoting Amit Nischal (2018-04-03 06:22:41)
> >> +
> >> +static struct clk_rcg2 gcc_usb30_prim_mock_utmi_clk_src = {
> >> + .cmd_rcgr = 0xf030,
> >> + .mnd_width = 0,
> >> + .hid_width = 5,
> >> + .parent_map = gcc_parent_map_0,
> >> + .freq_tbl = ftbl_gcc_usb30_prim_mock_utmi_clk_src,
> >> + .clkr.hw.init = &(struct clk_init_data){
> >> + .name = "gcc_usb30_prim_mock_utmi_clk_src",
> >> + .parent_names = gcc_parent_names_0,
> >> + .num_parents = 4,
> >> + .ops = &clk_rcg2_shared_ops,
> >
> > Still shared? Why?
>
> We would require the shared_ops for clocks which are configured by
> bootloader.

Why? The bootloader is not active anymore.

> >
> >> +
> >> + return qcom_cc_really_probe(pdev, &gcc_sdm845_desc, regmap);
> >> +}
> >> +
> >> diff --git a/include/dt-bindings/clock/qcom,gcc-sdm845.h
> >> b/include/dt-bindings/clock/qcom,gcc-sdm845.h
> >> new file mode 100644
> >> index 0000000..e27d8e2
> >> --- /dev/null
> >> +++ b/include/dt-bindings/clock/qcom,gcc-sdm845.h
> >> @@ -0,0 +1,242 @@
> > [...]
> >> +#define GCC_VDDA_VS_CLK
> >> 180
> >> +#define GCC_VDDCX_VS_CLK 181
> >> +#define GCC_VDDMX_VS_CLK 182
> >> +#define GCC_VS_CTRL_AHB_CLK 183
> >> +#define GCC_VS_CTRL_CLK
> >> 184
> >> +#define GCC_VS_CTRL_CLK_SRC 185
> >> +#define GCC_VSENSOR_CLK_SRC 186
> >> +#define GPLL4 187
> >
> > Do you have the define for the quad spi clks? And the implementation
> > for
> > it?
> >
>
> In SDM845, Quad SPI clocks are part of gcc_qupv*_wrap*_s* clock group.

Ok thanks. I must have messed up my math before because it didn't match
what bootloader was doing last time I checked.

\
 
 \ /
  Last update: 2018-04-19 01:36    [W:0.215 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site