lkml.org 
[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] regulator: Don't return or expect -errno from of_map_mode()
Hi,

On Wed, Apr 18, 2018 at 12:15 AM, Javier Martinez Canillas
<javier@dowhile0.org> wrote:
>> @@ -124,11 +124,12 @@ static void of_get_regulation_constraints(struct device_node *np,
>>
>> if (!of_property_read_u32(np, "regulator-initial-mode", &pval)) {
>> if (desc && desc->of_map_mode) {
>> - ret = desc->of_map_mode(pval);
>> - if (ret == -EINVAL)
>> + unsigned int mode = desc->of_map_mode(pval);
>
> I think the convention is to always declare local variables at the
> start of the function? Although I couldn't find anything in the coding
> style document...

I haven't seen this as a consistent kernel convention. It seems a bit
up to the subsystem and/or driver maintainer. However, I'm happy to
put it up at the top if it makes people happy.


>> @@ -163,12 +164,14 @@ static void of_get_regulation_constraints(struct device_node *np,
>> if (!of_property_read_u32(suspend_np, "regulator-mode",
>> &pval)) {
>> if (desc && desc->of_map_mode) {
>> - ret = desc->of_map_mode(pval);
>> - if (ret == -EINVAL)
>> + unsigned int mode = desc->of_map_mode(pval);
>> +
>> + mode = desc->of_map_mode(pval);
>
> You are calling .of_map_mode and assigning the return value twice here.

Dang it, thanks for catching.


-Doug

\
 
 \ /
  Last update: 2018-04-18 17:57    [W:0.058 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site