lkml.org 
[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.16 55/68] apparmor: fix display of .ns_name for containers
    Quoting Greg Kroah-Hartman (gregkh@linuxfoundation.org):
    > 4.16-stable review patch. If anyone has any objections, please let me know.
    >
    > ------------------
    >
    > From: John Johansen <john.johansen@canonical.com>
    >
    > commit 040d9e2bce0a5b321c402b79ee43a8e8d2fd3b06 upstream.
    >
    > The .ns_name should not be virtualized by the current ns view. It
    > needs to report the ns base name as that is being used during startup
    > as part of determining apparmor policy namespace support.
    >
    > BugLink: http://bugs.launchpad.net/bugs/1746463
    > Fixes: d9f02d9c237aa ("apparmor: fix display of ns name")
    > Cc: Stable <stable@vger.kernel.org>
    > Reported-by: Serge Hallyn <serge@hallyn.com>

    Excellent, thank you - this has been a pretty invasive bug for
    nested container usage.

    > Tested-by: Serge Hallyn <serge@hallyn.com>
    > Signed-off-by: John Johansen <john.johansen@canonical.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    >
    > ---
    > security/apparmor/apparmorfs.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > --- a/security/apparmor/apparmorfs.c
    > +++ b/security/apparmor/apparmorfs.c
    > @@ -1189,9 +1189,7 @@ static int seq_ns_level_show(struct seq_
    > static int seq_ns_name_show(struct seq_file *seq, void *v)
    > {
    > struct aa_label *label = begin_current_label_crit_section();
    > -
    > - seq_printf(seq, "%s\n", aa_ns_name(labels_ns(label),
    > - labels_ns(label), true));
    > + seq_printf(seq, "%s\n", labels_ns(label)->base.name);
    > end_current_label_crit_section(label);
    >
    > return 0;
    >

    \
     
     \ /
      Last update: 2018-04-18 17:07    [W:4.083 / U:1.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site