lkml.org 
[lkml]   [2018]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 09/49] media: v4l: vsp1: Fix header display list status check in continuous mode
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

    commit 613928e85317b945c863bb893f5737d2f22f5425 upstream.

    To allow dual pipelines utilising two WPF entities when available, the
    VSP was updated to support header-mode display list in continuous
    pipelines.

    A small bug in the status check of the command register causes the
    second pipeline to be directly afflicted by the running of the first;
    appearing as a perceived performance issue with stuttering display.

    Fix the vsp1_dl_list_hw_update_pending() call to ensure that the read
    comparison corresponds to the correct pipeline.

    Fixes: eaf4bfad6ad8 ("v4l: vsp1: Add support for header display lists in continuous mode")

    Cc: "Stable v4.14+" <stable@vger.kernel.org>
    Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/platform/vsp1/vsp1_dl.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/media/platform/vsp1/vsp1_dl.c
    +++ b/drivers/media/platform/vsp1/vsp1_dl.c
    @@ -508,7 +508,8 @@ static bool vsp1_dl_list_hw_update_pendi
    return !!(vsp1_read(vsp1, VI6_DL_BODY_SIZE)
    & VI6_DL_BODY_SIZE_UPD);
    else
    - return !!(vsp1_read(vsp1, VI6_CMD(dlm->index) & VI6_CMD_UPDHDR));
    + return !!(vsp1_read(vsp1, VI6_CMD(dlm->index))
    + & VI6_CMD_UPDHDR);
    }

    static void vsp1_dl_list_hw_enqueue(struct vsp1_dl_list *dl)

    \
     
     \ /
      Last update: 2018-04-17 18:39    [W:4.115 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site