lkml.org 
[lkml]   [2018]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space
    On Tue, Apr 17, 2018 at 04:02:33AM -0500, Vicentiu Galanopulo wrote:
    > A search of the dev-addr property is done in of_mdiobus_register.
    > If the property is found in the PHY node, of_mdiobus_register_vend_spec_phy()
    > is called. This is a wrapper function for of_mdiobus_register_phy()
    > which finds the device in package based on dev-addr, and fills
    > devices_addrs, which is a new field added to phy_c45_device_ids.
    > This new field will store the dev-addr property on the same index
    > where the device in package has been found.
    >
    > The of_mdiobus_register_phy() now contains an extra parameter,
    > which is struct phy_c45_device_ids *c45_ids.
    > If c45_ids is not NULL, get_vend_spec_addr_phy_device() is called
    > and c45_ids are propagated all the way to get_phy_c45_ids().
    >
    > Having dev-addr stored in devices_addrs, in get_phy_c45_ids(),
    > when probing the identifiers, dev-addr can be extracted from
    > devices_addrs and probed if devices_addrs[current_identifier] is not 0.

    This still needs work. But i don't want David to see the two
    Reviewed-by and think the series is O.K. So lets make it clear

    NACK

    More comments to follow.

    Andrew

    \
     
     \ /
      Last update: 2018-04-17 14:57    [W:3.254 / U:0.740 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site