lkml.org 
[lkml]   [2018]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 08/11] lightnvm: pblk: remove unnecessary argument
    From
    Date
    On 4/16/18 12:25 PM, Javier González wrote:
    > Remove unnecessary argument on pblk_line_free()
    >

    Why was the argument no longer needed?

    > Signed-off-by: Javier González <javier@cnexlabs.com>
    > ---
    > drivers/lightnvm/pblk-core.c | 6 +++---
    > drivers/lightnvm/pblk-init.c | 2 +-
    > drivers/lightnvm/pblk.h | 2 +-
    > 3 files changed, 5 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
    > index 6bc0c7f61aac..1b871441d816 100644
    > --- a/drivers/lightnvm/pblk-core.c
    > +++ b/drivers/lightnvm/pblk-core.c
    > @@ -1337,7 +1337,7 @@ static struct pblk_line *pblk_line_retry(struct pblk *pblk,
    > retry_line->emeta = line->emeta;
    > retry_line->meta_line = line->meta_line;
    >
    > - pblk_line_free(pblk, line);
    > + pblk_line_free(line);
    > l_mg->data_line = retry_line;
    > spin_unlock(&l_mg->free_lock);
    >
    > @@ -1562,7 +1562,7 @@ struct pblk_line *pblk_line_replace_data(struct pblk *pblk)
    > return new;
    > }
    >
    > -void pblk_line_free(struct pblk *pblk, struct pblk_line *line)
    > +void pblk_line_free(struct pblk_line *line)
    > {
    > kfree(line->map_bitmap);
    > kfree(line->invalid_bitmap);
    > @@ -1584,7 +1584,7 @@ static void __pblk_line_put(struct pblk *pblk, struct pblk_line *line)
    > WARN_ON(line->state != PBLK_LINESTATE_GC);
    > line->state = PBLK_LINESTATE_FREE;
    > line->gc_group = PBLK_LINEGC_NONE;
    > - pblk_line_free(pblk, line);
    > + pblk_line_free(line);
    > spin_unlock(&line->lock);
    >
    > atomic_dec(&gc->pipeline_gc);
    > diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
    > index 8f8c9abd14fc..b52855f9336b 100644
    > --- a/drivers/lightnvm/pblk-init.c
    > +++ b/drivers/lightnvm/pblk-init.c
    > @@ -509,7 +509,7 @@ static void pblk_lines_free(struct pblk *pblk)
    > for (i = 0; i < l_mg->nr_lines; i++) {
    > line = &pblk->lines[i];
    >
    > - pblk_line_free(pblk, line);
    > + pblk_line_free(line);
    > pblk_line_meta_free(line);
    > }
    > spin_unlock(&l_mg->free_lock);
    > diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h
    > index 856ac41e1201..ff0e5e6421dd 100644
    > --- a/drivers/lightnvm/pblk.h
    > +++ b/drivers/lightnvm/pblk.h
    > @@ -766,7 +766,7 @@ struct pblk_line *pblk_line_get_data(struct pblk *pblk);
    > struct pblk_line *pblk_line_get_erase(struct pblk *pblk);
    > int pblk_line_erase(struct pblk *pblk, struct pblk_line *line);
    > int pblk_line_is_full(struct pblk_line *line);
    > -void pblk_line_free(struct pblk *pblk, struct pblk_line *line);
    > +void pblk_line_free(struct pblk_line *line);
    > void pblk_line_close_meta(struct pblk *pblk, struct pblk_line *line);
    > void pblk_line_close(struct pblk *pblk, struct pblk_line *line);
    > void pblk_line_close_ws(struct work_struct *work);
    >

    \
     
     \ /
      Last update: 2018-04-17 14:13    [W:4.212 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site