Messages in this thread | | | Subject | Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error | From | Hans de Goede <> | Date | Tue, 17 Apr 2018 11:01:41 +0200 |
| |
Hi,
On 17-04-18 07:14, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB > Makefile does not currently build drivers/usb/common/ (where > USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify > the USB Makefile to always descend into drivers/usb/common/ > to build its configured targets. > > Fixes these build errors: > > ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined! > ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined! > ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined! > ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined! > > An alternative patch would be to select USB_COMMON in the EXTCON_AXP288 > driver Kconfig entry, but this would build more code in > drivers/usb/common/ than is necessary.
Ah, that variant of fixing this got posted yesterday and I acked that, but I agree that this version is better.
Greg, what is your take on this fix?
Chanwoo Choi, please wait with merging the fix from yesterday until we've a decision which fix to use.
Regards,
Hans
> > Reported-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: linux-usb@vger.kernel.org > --- > drivers/usb/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- lnx-417-rc1.orig/drivers/usb/Makefile > +++ lnx-417-rc1/drivers/usb/Makefile > @@ -60,7 +60,7 @@ obj-$(CONFIG_USB_CHIPIDEA) += chipidea/ > obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ > obj-$(CONFIG_USB_GADGET) += gadget/ > > -obj-$(CONFIG_USB_COMMON) += common/ > +obj-y += common/ > > obj-$(CONFIG_USBIP_CORE) += usbip/ > > >
| |