lkml.org 
[lkml]   [2018]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [SIL2review] [PATCH] i2c: img-scb: fix PM device usage count
    Date
    Hi,

    > Is it easily recognizable if the drivers check the error code because
    > there is a reason or if they do it "out of habit"?

    Probably by looking closely at the implementation of the PM callouts
    for the driver, but I couldn't find a pattern that would be easy to
    recognize. Maybe I didn't look close enough ;-)

    I concur that removing the check would be a better approach if it's
    clear that it's just done "out of habit".

    Actually, the real problem is to find the drivers that need to have
    the check in, add/fix it for them, and remove it for all others.

    Unfortunately, all I'm currently able to do is finding the parts that
    are inconsistent.

    Tobias

    \
     
     \ /
      Last update: 2018-04-17 10:20    [W:4.618 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site