lkml.org 
[lkml]   [2018]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers
From
Date
On 4/16/2018 4:51 PM, Jae Hyun Yoo wrote:
> On 4/16/2018 4:22 PM, Jae Hyun Yoo wrote:
>> On 4/16/2018 11:14 AM, Rob Herring wrote:
>>> On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote:
>>>> This commit adds dt-bindings documents for PECI cputemp and dimmtemp
>>>> client
>>>> drivers.
>>>

[...]

>>>> +Example:
>>>> +    peci-bus@0 {
>>>> +        #address-cells = <1>;
>>>> +        #size-cells = <0>;
>>>> +        < more properties >
>>>> +
>>>> +        peci-dimmtemp@cpu0 {
>>>
>>> unit-address is wrong.
>>>
>>
>> Will fix it using the reg value.
>>
>>> It is a different bus from cputemp? Otherwise, you have conflicting
>>> addresses. If that's the case, probably should make it clear by showing
>>> different host adapters for each example.
>>>
>>
>> It could be the same bus with cputemp. Also, client address sharing is
>> possible by PECI core if the functionality is different. I mean,
>> cputemp and dimmtemp targeting the same client is possible case like
>> this.
>> peci-cputemp@30
>> peci-dimmtemp@30
>>
>
> Oh, I got your point. Probably, I should change these separate settings
> into one like
>
> peci-client@30 {
>     compatible = "intel,peci-client";
>     reg = <0x30>;
> };
>
> Then cputemp and dimmtemp drivers could refer the same compatible
> string. Will rewrite it.
>

I've checked it again and realized that it should use function based
node name like:

peci-cputemp@30
peci-dimmtemp@30

If it use the same string like 'peci-client@30', the drivers cannot be
selectively enabled. The client address sharing way is well handled in
PECI core and this way would be better for the future implementations of
other PECI functional drivers such as crash dump driver and so on. So
I'm going change the unit-address only.

Thanks,

Jae

\
 
 \ /
  Last update: 2018-04-17 22:41    [W:0.053 / U:17.136 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site