lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] docs: kernel-parameters.txt: Fix whitespace
On Mon, Apr 16, 2018 at 02:08:46PM -0600, Jonathan Corbet wrote:
> On Mon, 16 Apr 2018 17:45:01 +0200
> Thymo van Beers <thymovanbeers@gmail.com> wrote:
>
> > Some lines used spaces instead of tabs at line start.
> > This can cause mangled lines in editors due to inconsistency.
> >
> > Replace spaces for tabs where appropriate.
>
> Seems like a fine idea. The patch doesn't apply, though; can you please
> make a version against current docs-next? (Or against 4.17-rc1 will work
> too).
>
> Also...
>
> > domain
> > - Isolate from the general SMP balancing and scheduling
> > - algorithms. Note that performing domain isolation this way
> > - is irreversible: it's not possible to bring back a CPU to
> > - the domains once isolated through isolcpus. It's strongly
> > - advised to use cpusets instead to disable scheduler load
> > - balancing through the "cpuset.sched_load_balance" file.
> > - It offers a much more flexible interface where CPUs can
> > - move in and out of an isolated set anytime.
> > -
> > - You can move a process onto or off an "isolated" CPU via
> > - the CPU affinity syscalls or cpuset.
> > - <cpu number> begins at 0 and the maximum value is
> > - "number of CPUs in system - 1".
> > + Isolate from the general SMP balancing and scheduling
> > + algorithms. Note that performing domain isolation this way
> > + is irreversible: it's not possible to bring back a CPU to
> > + the domains once isolated through isolcpus. It's strongly
> > + advised to use cpusets instead to disable scheduler load
> > + balancing through the "cpuset.sched_load_balance" file.
> > + It offers a much more flexible interface where CPUs can
> > + move in and out of an isolated set anytime.
> > +
> > + You can move a process onto or off an "isolated" CPU via
> > + the CPU affinity syscalls or cpuset.
> > + <cpu number> begins at 0 and the maximum value is
> > + "number of CPUs in system - 1".
>
> This would appear to have changed the indentation of some of the text?
>
> Thanks,
>
> jon

Thanks for the comment.

I will rebase against docs-next. Hadn't realised my tree wasn't
up-to-date.

Upon reviewing that section I see that was intentional indentation and
not some tab/space mix up.

Both will be fixed in v2.

- Thymo

\
 
 \ /
  Last update: 2018-04-16 23:49    [W:0.027 / U:25.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site