Messages in this thread | | | Subject | Re: [PATCH v3 2/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver | From | David Collins <> | Date | Mon, 16 Apr 2018 14:47:42 -0700 |
| |
Hello Taniya,
On 04/16/2018 10:38 AM, Stephen Boyd wrote: > Quoting Taniya Das (2018-04-13 19:36:41) >> Add the RPMh clock driver to control the RPMh managed clock resources on >> some of the Qualcomm Technologies, Inc. SoCs. >> >> Signed-off-by: David Collins <collinsd@codeaurora.org> >> Signed-off-by: Amit Nischal <anischal@codeaurora.org> > > Your signoff chain is very confused. The first signoff should match the > "From:" header but that doesn't seem to be the case here. And the sender > should be the last in the chain.
It looks like the provenance of this driver go muddled during downstream propagation between branches. The original downstream version of the clk-rpmh driver was written by Osvaldo Banuelos [1]. I think that the best course of action here would be to remove my Signed-off-by, add Osvaldo's, and add yours.
Thanks, David
[1]: https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=11d3623c37afb945ce36755501812a44efeb6cd9
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |