lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] doc: bindings: Add bindings documentation for mtd nvmem
On Sun, Mar 25, 2018 at 12:24:58AM +0100, Alban Bedel wrote:
> Config data for drivers, like MAC addresses, is often stored in MTD.
> Add a binding that define how such data storage can be represented in
> device tree.
>
> Signed-off-by: Alban Bedel <albeu@free.fr>
> ---
> Changelog:
> v2: * Added a "Required properties" section with the nvmem-provider
> property
> v3: * Fixed my name in From and Signed-off-by
> * Moved to the new nvmem binding with the nvmem-cells subnode
> ---
> .../devicetree/bindings/nvmem/mtd-nvmem.txt | 27 ++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt
>
> diff --git a/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt
> new file mode 100644
> index 0000000..c819a69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt
> @@ -0,0 +1,27 @@
> += NVMEM in MTD =
> +
> +Config data for drivers, like MAC addresses, is often stored in MTD.
> +An MTD device, or one of its partition, can be defined as a NVMEM provider
> +by having an 'nvmem-cells' subnode as defined in nvmem.txt.
> +
> +Example:
> +
> + flash@0 {
> + ...
> +
> + partition@2 {

This unit address is not correct...

> + label = "art";
> + reg = <0x7F0000 0x010000>;

Lowercase hex.

> + read-only;
> +
> + nvmem-cells {
> + compatible = "nvmem-cells";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + eeprom@1000 {

"eeprom" isn't specific data. The purpose of the nvmem binding is to
provide specific data fields like MAC addresseses.

Plus "eeprom" is the node name for EEPROM devices.

> + reg = <0x1000 0x1000>;
> + };
> + };
> + };
> + };
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2018-04-16 23:09    [W:0.060 / U:0.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site