lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes
    On Mon, 16 Apr 2018 17:09:38 +0000
    Sasha Levin <Alexander.Levin@microsoft.com> wrote:

    > Let's play a "be the -stable maintainer" game. Would you take any
    > of the following commits?
    >
    > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit?id=fc90441e728aa461a8ed1cfede08b0b9efef43fb

    No, not automatically, or without someone from KVM letting me know what
    side-effects that may have. Not stopping on a breakpoint is not that
    critical, it may be a bit annoying. I would ask the KVM maintainers if
    they feel it's critical enough for backporting, but without hearing
    from them, I would leave it be.

    > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit?id=a918d2bcea6aab6e671bfb0901cbecc3cf68fca1

    Sure. Even if it has a subtle regression, that's a critical bug being
    fixed.

    > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit?id=b1999fa6e8145305a6c8bda30ea20783717708e6

    I would consider unlocking a mutex that one didn't lock a critical bug,
    so yes.

    Again, things that deal with locking or buffer overflows, I would take
    the fix, as those are critical. But other behavior issues where it's
    not critical, I would leave be unless told further by someone else.

    -- Steve

    \
     
     \ /
      Last update: 2018-04-16 19:34    [W:4.205 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site