lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] perf list: Add s390 support for detailed/verbose pmu event description
On Mon, Apr 16, 2018 at 03:23:14PM +0200, Thomas Richter wrote:
> From: Thomas Richter <tmricht@linux.vnet.ibm.com>
>
> Perf list with flags -d and -v print a description (-d) or
> a very verbose explanation (-v) of CPU specific counter events.
> These descriptions are provided with the json files in
> directory pmu-events/arch/s390/*.json.
>
> Display of these descriptions on s390 requires the
> corresponding json files.
>
> On s390 this does not work because function is_pmu_core()
> does not detect the s390 directory name where the
> CPU specific events are listed. On x86 it is
> /sys/bus/event_source/devices/cpu
> whereas on s390 it is
> /sys/bus/event_source/devices/cpum_cf
> /sys/bus/event_source/devices/cpum_sf
>
> Fix this by adding s390 directory name testing to
> function is_pmu_core(). This is the same approach as taken for
> arm platform.

> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 1111d5bf15ca..8675ddf558c6 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -562,6 +562,12 @@ static int is_pmu_core(const char *name)
> if (stat(path, &st) == 0)
> return 1;
>
> + /* Look for cpu sysfs (specific to s390) */
> + scnprintf(path, PATH_MAX, "%s/bus/event_source/devices/%s",
> + sysfs, name);
> + if (stat(path, &st) == 0 && !strncmp(name, "cpum_", 5))
> + return 1;
> +

This shouldn't adversely affect ARM, so FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

\
 
 \ /
  Last update: 2018-04-16 16:44    [W:0.037 / U:3.348 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site