lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4 07/10] mfd: ti-lmu: register one backlight device per channel
On Fri, 30 Mar 2018, Sebastian Reichel wrote:

> All LMU devices support multiple channels, that can be controlled
> independently. This registers one backlight sub-device per channel.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
> drivers/mfd/ti-lmu.c | 62 +++++++++++++++++++++++++++++++++++++---------
> include/linux/mfd/ti-lmu.h | 4 +++
> 2 files changed, 54 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
> index f43b8acc30e1..f4311d215dfa 100644
> --- a/drivers/mfd/ti-lmu.c
> +++ b/drivers/mfd/ti-lmu.c
> @@ -56,8 +56,16 @@ static void ti_lmu_disable_hw(void *data)
>
> static const struct mfd_cell lm3532_devices[] = {
> {
> - .name = "ti-lmu-backlight",
> - .id = LM3532,
> + .name = "ti-lmu-led-backlight",
> + .id = 0,

What's the reason for you manually setting .id?

> + },
> + {
> + .name = "ti-lmu-led-backlight",
> + .id = 1,
> + },
> + {
> + .name = "ti-lmu-led-backlight",
> + .id = 2,
> },
> };

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2018-04-16 16:43    [W:0.052 / U:1.484 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site